View Single Post
Old 11-24-2020, 02:37 PM   #248
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,025
Karma: 4604635
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by DaltonST View Post
That fall-through should never been executed, since a unique name is passed by each and every menu action.
I would suggest that a non-unique default value for favourites_menu_unique_name, even as a fall though, would be contraindicated.

If every action has a favourites_menu_unique_name and the fall through never gets used, it doesn't matter. Until it does. So I don't think I'd keep that fall through at all. favourites_menu_unique_name is not required.
JimmXinu is offline   Reply With Quote