View Single Post
Old 11-24-2020, 02:14 PM   #246
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,045
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by DaltonST View Post
Favourites plugin issue, not LCs.
I just installed LC, briefly tested, and looked in the code. At the bottom of LC's version of common_utils.py, create_menu_action_unique() does this:

Code:
    # For use by the Favourites Menu plugin. If this menu action has text
    # that is not constant through the life of this plugin, then we need
    # to attribute it with something that will be constant that the
    # Favourites Menu plugin can use to identify it.
    favourites_menu_unique_name = 'Library Codes'
    if favourites_menu_unique_name:
        ac.favourites_menu_unique_name = favourites_menu_unique_name
Which explains why *all* LC menu options are named 'Library Codes'. Is that the intention? If so, why are different names passed in ui.py? I would speculate it was a bit of test code accidentally left in.

I've never delved deeply into how FM works, but it won't surprise me if it gets confused when handed a whole stack of items all with the same 'unique' name.
JimmXinu is offline   Reply With Quote