Thread: [GUI Plugin] Goodreads Sync
View Single Post
Old 11-07-2020, 05:03 AM   #1429
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,906
Karma: 47303748
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by Rellwood View Post
Hey, could you pretty please check out this bug report and see if you can identify why it takes so long to sync.
As always, you supply so little information with you reports that I you should not be surprised when you seem to be ignored. I mean, you should always state what you were actually doing. And I mean explicitly state the steps. And the versions in involve (which is why I always want a full debug log as will see the versions). And, most importantly, where you think the problem is. I mean, from the log, the only think I can guess is that you think there is to much time taken between the last two lines. Which of course leaves the other important piece of data, how many books are involved. Yes, that time is to long for 1 book, but, is it to long for 10? Or 100? Or a 1000?
Quote:
DEBUG: 15.4 sync_shelves - start
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: shelf='currently-reading', page=1
DEBUG: 18.4 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=currently-reading&page=1&per_page=200
DEBUG: 20.7 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 20.7 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 27.7 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'REMOVE', u'value': u'Placeholder.Maybe', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Pre-Ordered', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Waiting for it', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Want to Read', u'column': u'#book_style'}]
DEBUG: 28.0 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 28.0 sync_shelves - About to _update_goodreads_ids
DEBUG: 41.3 sync_shelves - finished _update_goodreads_ids
DEBUG: 47.6 sync_shelves - start
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: shelf='dnf', page=1
DEBUG: 50.7 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=dnf&page=1&per_page=200
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 181
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 193
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 230
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 54
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 260
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 228
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 154
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 319
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 34
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 160
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 236
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 315
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 62.0 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 64.6 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'DNF', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'ADD', u'value': u'DNF', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'1.Archived', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#grdateread'}, {u'action': u'REMOVE', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotic', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotica', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Re-reads', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Unread', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1/aNext up tbr', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'Amazon.On Deck', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'in1221', u'column': u'#details'}]
DEBUG: 67.4 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 67.4 sync_shelves - About to _update_goodreads_ids
DEBUG: 157.5 sync_shelves - finished _update_goodreads_ids

Actually, it is running a bit faster, but I am trying it on different shelves that either have a lot of reviews, or no review but both have no additional sync rules beyond updating two shelves. I will post the results
Now, looking at what happens between those last two lines, there is a problem. And there is a weird interaction between the progress bar and what is done that makes it a little longer. But, more importantly, there are some errors in that code that means that it is doing more work than it should, and, more importantly, not doing something that it is supposed to.

The attached beta should solve this. And it also has a lot of debugging output in between those last two lines that should give me a better idea of what is going on.
Last edited by davidfor; 12-25-2020 at 11:36 PM. Reason: Removed beta as it has been released.
davidfor is offline   Reply With Quote