View Single Post
Old 10-17-2020, 06:02 PM   #7
BetterRed
null operator (he/him)
BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.
 
Posts: 21,761
Karma: 30237526
Join Date: Mar 2012
Location: Sydney Australia
Device: none
Quote:
Originally Posted by chaley View Post
I think I can do this. Kovid is OK with it as long as the tag browser doesn't steal the focus at odd times such as when a dialog completes. My problem is a) testing that it is sufficiently complete to be useable, and b) that Kovid's condition isn't accidentally violated.

The goal: allow the tag browser to have keyboard focus. It would get it by clicking on something, or by using a keyboard shortcut I am adding. SHIFT-ESC returns the focus to the library view (an existing modifiable shortcut). Once there the arrow keys move up, down, in, and out of categories. The return key would "toggle" (search) the current item. The space key would open the context menu, which would also get the keyboard focus.

Do/can you run from source? That would make testing much easier and more complete, and avoid releasing something that is suboptimal.

*Expanded question*: does anyone who would use this run from source?
Thanks a lot for looking into this.

I don't run from source - but I guess I could for this. Be good if someone who normally does run from source could also test. Being of the 'near enough is good enough' school, I don't regard myself as a 'good' tester.

To help allay Kovid's concerns: How about an additional setting in Look & Feel->Enable tag browser keyboard interaction which defaults to unchecked, and/or only enable keyboard interaction if the new Focus the tag browser shortcut is used.

"The space key would open the context menu…" - I would much prefer to use the 'normal' context menu keys, i.e. the one that's normally next to the right Ctrl key, or Shift+F10. Also in other trees the space bar does nothing or does what a left mouse button click does - e.g. file managers show folder contents in main panel.


Aside: something I noticed a long time ago - Ctrl+Esc and Alt+Esc are the default shortcuts for Clear the virtual library and Clear the additional restriction, but Windows uses them to pop the Start Menu and switch between active tasks, and they takes precedence. There maybe other clashes I've not noticed.

BR
BetterRed is offline   Reply With Quote