Quote:
Originally Posted by compurandom
I'd be tempted to trap the errors, clear preferences for missing columns, and warn the user next time it is opened that some preferences were cleared.
|
That is what the commented out code actually does, but the problem for me is that it is not friendly to open duplicates dialog and have an error message pop instead, and only after you press OK be presented with the find duplicates dialog
Quote:
Originally Posted by compurandom
and force the user into the preferences dialog
|
There is no preference dialog to direct the user to, you have to check the settings when the user opens the plugin, and take the action then, as it stands now, if an error is found, it would pop a message detailing what went wrong.
Quote:
Originally Posted by compurandom
print some warnings to the debug log
|
The restore code already does that, but this going to be missed by most users because you don't normally start calibre in debug mode, and even if you did, you probably miss it if only one template failed in a multi-algorithm rule.
Quote:
Originally Posted by Terisa de morgan
I'm not a fan of giving the information about the error in the debug log, I think that a message as: "xxxxx" preferences are not longer valid, or something like that, is useful, and clearing that default.
|
Attached below is what happens when you try to restore a saved setting that contains missing columns or templates.
I thought that the presence of the saved settings feature might be enough for people since you restore it with just a one click, Apparently not.
So, I decided to wait on automatic restore of last used settings until I have clear picture of how to do it. Because if I proceed now and changed my mind later, I will have to bump the config file schema version, and add code to convert user's old settings to the conform with the new schema, which I don't really want to do.