View Single Post
Old 10-03-2020, 10:38 PM   #18
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 79,891
Karma: 146918083
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
Quote:
Originally Posted by DNSB View Post
Add a minimum version check so the Python 3 version won't install on a calibre version less than 5. Ghod knows enough plugins already have that minimum version check baked in.

Look at the Job Spy plugin for example. In it's root __init__.py, you find the following lines:

Code:
    name                    = 'Job Spy'
    description           = JS_DESCRIPTION
    supported_platforms     = ['windows', 'osx', 'linux']
    author                  = 'DaltonST'
    version                 = (1, 0, 184)
    minimum_calibre_version = (4, 6, 0)    # originally 2.49.0
Change that tuple to (5,0,0) and happily forget Python 2.
But what about the Python 2 compatible version? How would that e handled along side a Python 3 version with the same name?
JSWolf is offline   Reply With Quote