View Single Post
Old 10-03-2020, 07:45 PM   #17
DNSB
Bibliophagist
DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.
 
DNSB's Avatar
 
Posts: 47,053
Karma: 169810634
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
Quote:
Originally Posted by JSWolf View Post
But can there be two plugin with the same name? There is no way for Calibre to know if a plugin is Calibre 5 compatible or not. So what happens? If there is a name change, anyone using this plugin who is not on MR won't know it's the same plugin just for Calibre 5.
Add a minimum version check so the Python 3 version won't install on a calibre version less than 5. Ghod knows enough plugins already have that minimum version check baked in.

Look at the Job Spy plugin for example. In it's root __init__.py, you find the following lines:

Code:
    name                    = 'Job Spy'
    description           = JS_DESCRIPTION
    supported_platforms     = ['windows', 'osx', 'linux']
    author                  = 'DaltonST'
    version                 = (1, 0, 184)
    minimum_calibre_version = (4, 6, 0)    # originally 2.49.0
Change that tuple to (5,0,0) and happily forget Python 2.
DNSB is offline   Reply With Quote