View Single Post
Old 09-30-2020, 05:41 AM   #1512
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,477
Karma: 8025702
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
The behavior difference that @Rev. Bob pointed out is almost certainly benign. but it does bother me a bit. And it turns out not to be necessary. I decided to use the python version to condition the magic of how EOL is treated. The attached version preserves EOLs.

It should be noted that the plugin explicitly changes CRLF to LF in a ton of places depending on options. Because of this, one cannot depend on preserving CRLF. They are preserved if only "Update Metadata" is checked, so basic file IO works.

The change has no impact on the plugin running on 4.23.

I am tempted to release this version but that would be tempting fate. I will do so later today (around 9 AM GMT) unless 'bad things happen'.

Last edited by chaley; 09-30-2020 at 06:54 PM. Reason: Obsolete zip version deleted
chaley is offline   Reply With Quote