Thread: [GUI Plugin] Modify ePub
View Single Post
Old 09-27-2020, 05:30 AM   #1448
Rev. Bob
Wizard
Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.Rev. Bob ought to be getting tired of karma fortunes by now.
 
Rev. Bob's Avatar
 
Posts: 1,760
Karma: 9918418
Join Date: Feb 2013
Location: Here on the perimeter, there are no stars
Device: Kobo H2O, iPad mini 3, Kindle Touch
Quote:
Originally Posted by chaley View Post
As for me.py, I don't think renaming is needed. There can (should) be only one version of the PI installed so there can't be name collisions.
My thinking there was about people who find ways to install multiple versions of calibre – in this case, to keep 4.x around while testing 5.x – and might run into collisions if the plugins wind up in either the same folder or the same path. That’s probably enough of an edge case that it’s not worth worrying about, but I get paranoid.

Quote:
Originally Posted by kovidgoyal View Post
There is no need to fork, simply set the minimum_calibre_version in _init__.py to 5, 0, 0 then users on calibre 4 wont be allowed to upgrade (at least that's how my memory of the plugin update system says it works).
Useful information indeed, and if I follow your logic here:

Quote:
The only down side is anyone on calibre 4 that does not already have the plugin, will not be able to install it. If you wish to cater to such people, I suggest a fork with this plugin remaining the main one and support calibre 5+ while the fork can be for calibre < 5 people.
…then basically, when the port is ready, the currently-live version’s download file could get renamed to something like “Modify ePub (legacy)” and the ported/new version would stay “Modify ePub” but add the minimum-version-5.0.0 setting to prevent 4.x users from upgrading to it by mistake. (Is there a “maximum version” setting that could get set to something like 4.99.99? The current file could implement that right now, if so.)

Yeah, I could get down with that idea. I hate breaking backward compatibility on general principles, but leaving an active fallback version would alleviate that. And then, down the line, if somebody were to look at the pair and say, “hey, I can fuse these into a universal edition,” so much the better. Meanwhile, if forking makes it easier to get a good fix faster, that’s a win for the community at large.

Again, just a spectator in this process, but this sounds like a plan.
Last edited by Rev. Bob; 09-27-2020 at 05:34 AM.
Rev. Bob is offline   Reply With Quote