View Single Post
Old 09-21-2020, 02:27 PM   #919
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 6,999
Karma: 4604635
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
@compurandom's interpretation seems to me to be most technically accurate, if you take the time to think about it deeply. (OTOH, I also suspect that compurandom may be the only user in the world who wants it to work that way.)

I also don't want to deal with the inevitable users who fiddled that 'modify type' setting and left it on something other than 'add or remove' and suddenly don't get the behavior they had before.

RL already had a migrate_library_config_if_required() method built-in. The most logical thing to do may be to use that to force-change all pre-existing pop-from-device lists to 'add or remove' to match prior behavior and then honor the modify action setting.
JimmXinu is offline   Reply With Quote