Thread: [GUI Plugin] Reading List
View Single Post
Old 09-21-2020, 10:21 AM   #917
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by compurandom View Post
The existing behaviour could be done just by having the pulldown set to add/remove rather than add only.

This looks like a bug to me -- if you're going to ignore the option in the pulldown, then grey out the pulldown like is done for the next section. The surprising behavior is to ignore the pulldown.
All those things could be done. But, I was basing my comments on my understanding of how the plugin works, plus the code that @JimmXinu posted. That code is very deliberate. And it uses a parameter to a method that is not used anywhere except in those lines. In fact, it looks like the parameter was added specifically for this.

But, overall, it doesn't worry me that much. I don't use that type of list. The fact that it changes the modified date every time the device is connected drove me nuts when I did use it.
davidfor is offline   Reply With Quote