Thread: calibre 5: Beta testers needed
View Single Post
Old 07-28-2020, 03:12 PM   #94
thiago.eec
Wizard
thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.thiago.eec ought to be getting tired of karma fortunes by now.
 
Posts: 1,220
Karma: 1419583
Join Date: Dec 2016
Location: Goiânia - Brazil
Device: iPad, Kindle Paperwhite, Kindle Oasis
Quote:
Originally Posted by kovidgoyal View Post
Released version 4.99.9 with the following changes:

0) The viewer now supports books with right-to-left text
1) the selection bar is now fully customizable and can be disabled
2) There are new actions that can be added to the bar for one click highlight and highlight adjusting selections, and removing highlights
3) The selection bar is hidden while mouse dragging is in progress
4) The bug with the browse annotations tool restriction to types not working has been fixed
5) Multi-select is allowed int he viewer highlights panel
6) Copy button in selection bar now present in browser viewer as well
Great work, Kovid!

My impressions:

1) Very nice solution making the bar customizable.
2) The bar only appearing after the selection is finished is way better.
3) The new Quick Highlight is perfect.
4) Now the highlights are instantaneously showing in "Browse annotations" in main calibre, without having to restart (at least, this was needed for me before).

Suggestions:

1) I agree with @nixsse about different icons for Notes and Quick Highlight. I suggest changing the Notes icon, since the marker pen is ideal to represent highlighting.
2) As I suggested before, and others too: allow multi-selection, exporting and deleting from "Browse annotations" on main calibre.
3) When a book is already open, clicking on a highlight should take us to it, without opening the book again.

Bugs:

1) As reported by @The_Ad, every two clicks on "Browse annotations" make it blank.
2) Highlights are getting duplicated after I added the server user to sync with. The highlights were done in the local viewer, but they were also assigned to the server user. So, when the user dropdown is "empty", the notes/bookmarks appear duplicated. I know they are supposed to sync, but shouldn't it be displayed only once, under the original creator?
3) If a user is added once for syncing with server, even after removing it from the server and the viewer preferences, it remains listed on the dropdown menu on "Browse annotations". Actually, the viewer seems to be unaware of server users, so you can even add a non-existent user for syncing.
4) Clicking on "Edit" on "Browse annotations" on the viewer gives this error:
Spoiler:

Code:
calibre, version 4.99.9
ERRO: Error in message handler: TypeError: Cannot read property 'frameElement' of undefined

Traceback (most recent call last):
    at IframeClient.handle_message (userscript:viewer.js:15123:21)
    at IframeBoss.annotations_msg_received (userscript:viewer.js:23054:26)
    at IframeBoss.snap_to_selection [as ensure_selection_visible] (userscript:viewer.js:19342:45)
    at ScrollViewport.ρσ_interpolate_kwargs (userscript:viewer.js:2616:18)
    at ScrollViewport.viewport_to_document (userscript:viewer.js:12147:41)
TypeError: Cannot read property 'frameElement' of undefined

Info:
1) The "Browse annotations" button is not available on the server viewer. Is this expected?
thiago.eec is offline