Thread: [Device Plugin] Kobo Touch Extended Driver
View Single Post
Old 06-22-2020, 09:56 PM   #2249
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by NiLuJe View Post
Good news: the empty OPF thingy is my fault (oops). No idea how I failed to notice it the first time around :/.

https://github.com/jgoguen/calibre-kobo-driver/pull/108 *should* fix it, but I wouldn't mind another pair of eyes on this (especially from people who actually know what they're doing ^^).
Looking at the change, it makes sense. When I looked at late last night/early this morning, I couldn't work out why the StringIO was needed at all, but, couldn't work how to fix it. I shouldn't have been trying to code at that time (I was up monitoring a work change being done by someone else).

I've done a quick test here, and it seems to be OK. My tests used both the Embed metadata and send-to-device.
davidfor is offline   Reply With Quote