Thread: [GUI Plugin] Extract ISBN
View Single Post
Old 06-21-2020, 03:52 AM   #375
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by qwertyuio View Post
Here is an update of the python 3 beta to include the ability to use OCR to get the ISBN from scanned PDF files. I've tested it on Windows and Linux. It requires Tesseract to be installed for the OCR to work. If it is not installed the plugin will work the same as before.

Windows binaries of Tesseract are here. You will need to add it to your PATH as the Windows Tesseract installer does not do this.
My apologies for not responding to this before. I was thinking that I had commented, but, I suspect I looked at your version and then put off replying until I had some time. And you can see what happened

I can see that this should be a good idea. But, I'm very much against hardcoding external dependencies like this. And especially then requiring they are in the path. It would be much better to make the executable a configurable. And maybe have an option to turn it on and off. But, maybe I am over thinking this.

In any case, as I said above, this isn't a plugin I use. I mainly did the Python 3 changes because it was installed and the errors when starting calibre was hiding other things. As there weren't many changes, I made them, and added the translations. Both needed relatively minor changes. And beyond some basic testing, I haven't used it. So, I'm going to release my Python 3 compatible and then step back. I'll let people who do use the plugin decide the future of it. And yes, that means I'm chickening out
davidfor is offline   Reply With Quote