View Single Post
Old 06-20-2020, 07:54 AM   #33
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,911
Karma: 6120478
Join Date: Nov 2009
Device: many
After staring that the blink renderer code for some time, it is clear a bad/partial merge from Chrome was introduced into Qt 5.12.8 and Qt 5.12.9. Somebody reversed a test condition to make it easier to understand but forgot to swap the then and else clauses and as a result completely reversed the logic in places.

I checked the Chrome 80 sources and this bug does not exist (the if test was reversed as were the then and else clauses) so that explains why Qt 5.15 seems to work.

I have now fixed that bug and I am rebuilding Qt once again to see if this fixes our issue or if there is more breakage that needs to be tracked down.

What a mess!

Last edited by KevinH; 06-20-2020 at 09:39 AM.
KevinH is offline   Reply With Quote