View Single Post
Old 06-17-2020, 12:03 AM   #2170
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,419
Karma: 27757236
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
This doesnt have anything to do with python. Its unsafe to execute arbitrary python, so the plugin mirroring service instead has an adhoc parser that I wrote based on the python stdlib ast module to extract plugin metadata from __init__.py, without needing to execute anything. Over the years as plugin developers have gotten more creative in how they choose to define versions the parser has had to support more and more python syntax. In this case, it was tripping up on import common and version = common.WHATEVER if you had instead done from common import WHATEVER version = WHATEVER it would have worked, already, but no big deal, since the fix was fairly simple.
kovidgoyal is offline   Reply With Quote