Thread: [GUI Plugin] Quality Check
View Single Post
Old 05-31-2020, 06:44 AM   #1002
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by warrimoo View Post
Thanks, and Yes, in this particular case the script looks like this:


<noscript><!-- BEGIN STANDARD TAG - 728 x 90 - Lycos - Angelfire Fallthrough - DO NOT MODIFY -->
<iframe class="calibre5" frameborder="0" height="90" marginheight="0" marginwidth="0" scrolling="no" src="http://ad.yieldmanager.com/st?ad_type=iframe&amp;ad_size=728x90&amp;section=2 80303" width="728"></iframe> <!-- END TAG --></noscript>

The preview in the Calibre editor fires this script from the <body> as well. So it would be really good to have a way to generically detect and deactivate this sort of code without directly opening the editor. I guess a regexp check for <noscript> is probably a first pass for the more literate, but adding functionality to the plugins might be helpful for everyone. The payload in this particular case is mild.
Yes, it should be easy to remove with a regex in the editor. And it shouldn't be to hard to do in something like the Modify ePub plugin. The problem is going to be whether anyone is interested in adding the function. It doesn't feel like a very common function. You should ask in the plugin's thread and see.
davidfor is offline   Reply With Quote