View Single Post
Old 05-28-2020, 02:32 PM   #8
pazos
cosiņeiro
pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.
 
Posts: 1,406
Karma: 2451781
Join Date: Apr 2014
Device: BQ Cervantes 4
Quote:
Originally Posted by chaley View Post
This one is more difficult because a new opcode coming from calibre could break all the existing clients. We got away with ERROR because calibre never sends it.

What I can do: when calibre tells the device to eject, send a NOOP with an argument {'ejecting': True} just before I close the socket. Existing clients shouldn't break (CC won't). This won't prevent calibre from simply closing the socket sometimes because there are ways for the driver to be shutdown without being told why.

Is this OK? If so I will submit changes.
Totally OK!

Thank you!!!
pazos is offline   Reply With Quote