Quote:
Originally Posted by pazos
Another thing I noticed: the wireless server doesn't notify clients when its "ejecting" the drive. It just closes the socket.
It would be amazing to send a new opcode to figure out that the user intention is to disconnect the "disk" and it isn't just a temporarily failure on talking with the server.
|
This one is more difficult because a new opcode coming from calibre could break all the existing clients. We got away with ERROR because calibre never sends it.
What I can do: when calibre tells the device to eject, send a NOOP with an argument {'ejecting': True} just before I close the socket. Existing clients shouldn't break (CC won't). This won't prevent calibre from simply closing the socket sometimes because there are ways for the driver to be shutdown without being told why.
Is this OK? If so I will submit changes.