Quote:
And, I had to spend far to much time working out what you were suggesting. On my first read of the post I had no idea what you wanted for either option. If you had stated the purpose, not just described the code changes needed, it would have made a lot more sense. And, I'm still not sure if I am understood the requests properly.
|
Noted, hopefully my explanations below will help you understand why without these changes the Kobo plugin doesn't work in my use case and why I requested them and that these changes do not effect any other users.
Quote:
Um, I think you want to allow localising the search to specific nations and languages. I have done this, and my testing didn't give any real advantage. And, if I remember rightly, caused as many issues as the current way of doing it.
|
Actually the current way of doing it already localises to the IP. I want to avoid this and make localising at least user configurable. Without the proposed change if you're making a request from say an Italian IP all your tag's will be in Italian. So it is a requirement if you're abroad and want English tags.
In my testing it works well if you apply the change to the STORE_DOMAIN variables. I understand that you may not want to support languages other than English(which the default already does..). Then I request that you add "/en" to each of the store domains, that would solve the issue of tags being returned in other language.
Quote:
The point of using a dot is because that is how calibre works with tag hierarchy. I can think of any benefit for using any other character. I suspect you are trying to match with how Goodreads does it. And, I just don't see the point. Calibre has a well structured handling of tags, and you seem to be suggesting a change that will be inconsistent with other metadata sources.
|
I am not suggesting a change to the default settings, I am requesting the end user be able to set up what suits their use case - without hacking at the code. I am using calibre-web to browse my library which doesn't support hierarchical tags. It list all tags on one page. This change makes the tags much more readable.
Here is an example of what it looks like:
https://ibb.co/G5kWnmB
Note, I am actually not interested in using Goodreads tag's. I'd like to stick to one source and one categorisation. It is not a concern now but perhaps in the future, if I can figure out a way to map Goodreads tags to Kobo Books Categories I might do that.
I am not asking you to rethink your way of doing it, I am asking you to add in some user variables. Every set up is different and without these changes the Kobo plugin won't work for some people.
Thank you again.