View Single Post
Old 05-17-2020, 03:57 AM   #66
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by DictatorAlly View Post
That could be helpful.

Can I make some suggestions to changes to the Plugin?

I'd like two options to be added to the configuration page. Each option would be a blank text box, so that the user can define them how best suits - saving the need to create an exhaustive list.


One option would correspond to this " > "
Code:
if self.category_handling == 'hierarchy' and i > 0:
    tag = tag + " > " + raw
The point of using a dot is because that is how calibre works with tag hierarchy. I can think of any benefit for using any other character. I suspect you are trying to match with how Goodreads does it. And, I just don't see the point. Calibre has a well structured handling of tags, and you seem to be suggesting a change that will be inconsistent with other metadata sources.
Quote:
The next option would correspond to this "it"
Code:
SEARCH_PATH = '/it/search'
So that the user can add "it" or "it/it" or "us/it" whatever works for them.
Um, I think you want to allow localising the search to specific nations and languages. I have done this, and my testing didn't give any real advantage. And, if I remember rightly, caused as many issues as the current way of doing it.


And, I had to spend far to much time working out what you were suggesting. On my first read of the post I had no idea what you wanted for either option. If you had stated the purpose, not just described the code changes needed, it would have made a lot more sense. And, I'm still not sure if I am understood the requests properly.
davidfor is offline   Reply With Quote