View Single Post
Old 05-07-2020, 02:45 PM   #179
xvicarious
Junior Member
xvicarious began at the beginning.
 
Posts: 6
Karma: 10
Join Date: May 2020
Device: KindlePW5
I did use "calibre.ebooks.BeautifulSoup", but for a lot of the webscraper it just isn't used and just sits there and does nothing. Soup is made, but rarely used. And a lot of string manipulation is used when using BS is much more efficient. For example "parse_html_viaf" was 67 lines (counting empty and comments) uses 2 separate for loops to go through the same information to get different things. Essentially I just made it more simple, a single loop, using the tools (like calibre.ebooks.BeautifulSoup) provided. It is now 23 lines using the same metric.

Also I had no intentions of starting my own plugin/fork, I just figured because of the license of it I would take the chance to improve upon it. You're welcome to use the improvements I made of course due to the nature of the license and that I did for anyone who wanted it.
xvicarious is offline   Reply With Quote