View Single Post
Old 04-13-2020, 10:33 PM   #1356
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by soundium View Post
I am sorry, but it seems you have not checked my screenshot. From a logic point of view and UI calibre make it correct. Why do we need another bike if we have already one?

At the end of the day, it is just a suggestion that helps the user. If you think it is wrong or useless... let us focus only on fixing.
The problem is that I do not think that the methods used for downloading bulk metadata is suitable for use with linking the Goodreads book in this plugin. I do not think that doing an "accept all" is valid for this plugin. Based on my use, there are far to many cases were this would get the wrong book. And that includes when only one match is found.

For the individual book part, I do not think that the words used on the buttons are wrong. And I think that using the words that the bulk metadata download use would be wrong. The button "OK" is not perfect, but your suggestion of "Approve" is wrong. "Accept" might be correct, but, I don't really think it is much better than "OK". "Reject" is definitely wrong and I consider that "Skip" is a better description of the action.
davidfor is offline   Reply With Quote