View Single Post
Old 04-12-2020, 02:22 PM   #1385
DNSB
Bibliophagist
DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.DNSB ought to be getting tired of karma fortunes by now.
 
DNSB's Avatar
 
Posts: 47,160
Karma: 169815798
Join Date: Jul 2010
Location: Vancouver
Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos
Quote:
Originally Posted by Rev. Bob View Post
Not so minor, to do it properly:

In other words, while the cover document is the most common place this would be found, it’s not at all the only one. A proper implementation of this feature would have to scan every file in the ebook for SVG markup and flag all of them appropriately. That’s a significantly nastier can of worms.
I was not asking for Modify Epub to check every file and add that propery if needed. What I do want is for Modify Epub to do this for the cover file it inserts. The other files are either going to be already correctly labelled or I will have fixed them as part of my cleanup before I run Modify Epub.


Quote:
Originally Posted by Rev. Bob View Post
I mean, there’s nothing conceptually wrong with saying, in effect, “I’m changing the cover and specifying SVG markup, therefore I should check the EPUB version and see if I need to slap the properties attribute on it in the OPF” – but that still leaves the rest of the ebook unchecked, just waiting to generate those validation errors you want to avoid.

And then, on top of all that, the code has to deal with the possibility that a properties attribute already exists, meaning it has to be checked and correctly modified…
Again, I wasn't asking for Modify Epub to check this for the entire epub, just for a cover image inserted into an epub3 by Modify Epub.
DNSB is offline   Reply With Quote