MobileRead Forums - View Single Post

Doitsu · 04-10-2020, 11:33 AM

IMHO, your plugin is almost ready for an official release. I only have one minor nitpick: the plugin never reads or writes the "metas" preference setting.

I also have a minor suggestion:

if you change:

Code:

        tags = soup.find_all(ttags, class_=re.compile("calibre"))

to:

Code:

        if ttags == ['']:
            tags = soup.find_all(class_=re.compile("calibre"))
        else:
            tags = soup.find_all(ttags, class_=re.compile("calibre"))

the user can use the following preference setting:

Code:

  "tags": ""

to tell the plugin to remove calibre classes from all tags.

04-10-2020, 11:33 AM	#14
Doitsu Grand Sorcerer Posts: 5,739 Karma: 24031403 Join Date: Dec 2010 Device: Kindle PW2	IMHO, your plugin is almost ready for an official release. I only have one minor nitpick: the plugin never reads or writes the "metas" preference setting. I also have a minor suggestion: if you change: Code: tags = soup.find_all(ttags, class_=re.compile("calibre")) to: Code: if ttags == ['']: tags = soup.find_all(class_=re.compile("calibre")) else: tags = soup.find_all(ttags, class_=re.compile("calibre")) the user can use the following preference setting: Code: "tags": "" to tell the plugin to remove calibre classes from all tags.