Thread: Sigil-1.2.0 Released
View Single Post
Old 03-31-2020, 02:03 AM   #19
BetterRed
null operator (he/him)
BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.
 
Posts: 21,825
Karma: 30277270
Join Date: Mar 2012
Location: Sydney Australia
Device: none
Quote:
Originally Posted by DiapDealer View Post
It's not set in the current code. But it was there at one point. I believe it's still there (but commented out) in Book Browser. I don't remember which version we fixed it in, but there was at least one release that tried to assign Ctrl Alt R to both Rename and Regex Rename. And Regex Rename came last.

EDIT: my mistake. it was the BookBrowser "Move" function that was also assigned the Ctrl Alt R shortcut at some point.
https://github.com/Sigil-Ebook/Sigil...wser.cpp#L1736

We had duplicate m_Rename actions for a time (for Rename and Regex Rename).
https://github.com/Sigil-Ebook/Sigil...e881d1a5a25cd8

I believe that was probably the cause of the rename shortcut not working for a time (depending on which version of Sigil created the default shortcuts).
As you can imagine I'm sitting here, confined to barracks, having a quiet chuckle.

I know it wasn't you guys, and that it's too late now, but IMO not using F2 for file rename is like not using ctrl+c, ctrl+v for coffee and pasta. Needless to say that's what I have changed it to

BR
BetterRed is offline   Reply With Quote