View Single Post
Old 03-30-2020, 09:32 PM   #17
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,709
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
Where in the current code is Ctrl Alt R set anyplace for RERenamer? I checked the code in BookBrowser, main.ui, MainWindow, and RERenamer.ui and I could not see a shortcut set. Only Rename gets that shortcut set in BookBrowser.
It's not set in the current code. But it was there at one point. I believe it's still there (but commented out) in Book Browser. I don't remember which version we fixed it in, but there was at least one release that tried to assign Ctrl Alt R to both Rename and Regex Rename. And Regex Rename came last.

EDIT: my mistake. it was the BookBrowser "Move" function that was also assigned the Ctrl Alt R shortcut at some point.
https://github.com/Sigil-Ebook/Sigil...wser.cpp#L1736

We had duplicate m_Rename actions for a time (for Rename and Regex Rename).
https://github.com/Sigil-Ebook/Sigil...e881d1a5a25cd8

I believe that was probably the cause of the rename shortcut not working for a time (depending on which version of Sigil created the default shortcuts).

Last edited by DiapDealer; 03-30-2020 at 09:49 PM.
DiapDealer is offline   Reply With Quote