MobileRead Forums - View Single Post - Koreader Emulator on a Macbook (retina display)

Frenzie · 02-28-2020, 01:39 PM

@pazos But when I put in the PR for removing SDL 1.2 you said something like "be gone legacy stuff /thumbs up" :P

@jbenwell We do that manually with https://github.com/koreader/ffi-cdecl As long as it's in SDL2_0_decl.c it should be fine.

Anyway, if you really must put in that condition, you should use the SDL_Linked_Version_AtLeast function I put in place for that very reason. Well, except I implicitly did not intend for it to check for 2.0.1, just for newer than 2.0.4. It's quite possible the program is broken on <2.0.4 because no one's tested that in half a decade.

02-28-2020, 01:39 PM	#15
Frenzie Wizard Posts: 1,769 Karma: 731681 Join Date: Oct 2014 Location: Antwerp Device: Kobo Aura H2O	@pazos But when I put in the PR for removing SDL 1.2 you said something like "be gone legacy stuff /thumbs up" :P @jbenwell We do that manually with https://github.com/koreader/ffi-cdecl As long as it's in SDL2_0_decl.c it should be fine. Anyway, if you really must put in that condition, you should use the SDL_Linked_Version_AtLeast function I put in place for that very reason. Well, except I implicitly did not intend for it to check for 2.0.1, just for newer than 2.0.4. It's quite possible the program is broken on <2.0.4 because no one's tested that in half a decade.