View Single Post
Old 02-14-2020, 03:51 PM   #13
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,439
Karma: 5703082
Join Date: Nov 2009
Device: many
If we decide to go this way, we could make a static routine that takes a passed in QMenu * and a passed in Resource Type and adds a context menu (of the right type) to the QMenu. OpenExternally may be the right place to store the code that builds that menu as it has only static routines now. It may work but as you said it would be a very very messy change for not much payback.

KevinH


Quote:
Originally Posted by DiapDealer View Post
And after looking; I can say that it probably wouldn't be that easy to do. Not without a lot code duplication anyway. The "Open With" functionality itself isn't that difficult. But the building of a dynamic context menu to accommodate it all is a bit tedious. It would involve a lot of refactoring I think.

There IS a deprecated QSignalMapper in there, though, that I'd like to eliminate regardless.
KevinH is offline   Reply With Quote