View Single Post
Old 01-31-2020, 10:43 PM   #4
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by kovidgoyal View Post
That's an error in the open with plugin. I sggest uninstalling it. calibre anyway has builtin open with functionality.
The plugin does a lot more as it has a menu of options for opening the books with appropriate parameters passed to the executable.

I'm also not able to reproduce the problem here with various versions of calibre. The code in question is:

Code:
        for action in self.menu_actions:
            self.gui.keyboard.unregister_shortcut(action.calibre_shortcut_unique_name)
            # starting in calibre 2.10.0, actions are registers at
            # the top gui level for OSX' benefit.
            if calibre_version >= (2,10,0):
                self.gui.removeAction(action)
"action" is a "QAction". The lines above are fairly common thing in the plugins. Which might just means we copied from a common source and it isn't really needed. But, I can see it in several places in calibre.

The OP has three other plugins installed that use the above. And they should be called when the library changes. Is this something we shouldn't be doing then?
davidfor is offline   Reply With Quote