View Single Post
Old 01-24-2020, 09:13 PM   #7
Tex2002ans
Wizard
Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.Tex2002ans ought to be getting tired of karma fortunes by now.
 
Posts: 2,306
Karma: 13057279
Join Date: Jul 2012
Device: Kobo Forma, Nook
Quote:
Originally Posted by phossler View Post
Same here using 4.9.1 - didn't used to do that
Agreed. Perhaps it was some recent addition.

In the Calibre 4.9.1 release notes it mentions:

Quote:
Edit book: The Check book function has a new, improved CSS checker with support for CSS 3
Perhaps this was an accidental regression that was introduced.

Quote:
Originally Posted by phossler View Post
I know it's only a warning, but I think it's a wrong warning since I think it's allowed by the CSS gods

From the 'detailed description' link
Here's the exact URL the "detailed description" links to:

https://github.com/CSSLint/csslint/w...e-defined-once

... very odd. I don't agree with that at all.

I can understand Check Book pointing out an (accidental) duplicate in your CSS:

h1, h2, h3, h4 { }
h2 { }
h2 { }

but pointing out ones that aren't the same?

h2
h2.title
h2.author

Quote:
Originally Posted by JSWolf View Post
That is much nicer code.
No. I'll have to agree with phossler and hobnail on this one.

Sometimes it's easier to have a centralized location for shared CSS, and then specific overrides in a different location.

Side Note: And I would strongly recommend against adding hyphens: none though. Think big words ("Acknowledgements"), with big font, on tiny devices (cell phone). Just leave that setting up to user devices/preferences.

Last edited by Tex2002ans; 01-24-2020 at 09:18 PM.
Tex2002ans is offline   Reply With Quote