Quote:
Originally Posted by BetterRed
The original developer (kiwidude) logs in occasionally, I suggest you send him a PM as a courtesy.
|
Thanks for that. I'll shoot him a PM shortly.
Quote:
|
Use whatever version control you're comfortable with, but the distribution of the release versions must be via the Plugin Updater process - as per the stickies at the top of the Plugins sub-forum. The forum lacks a facility to assign a thread to a different member; so, that means having to ask one of the active mods (me, theducks, DoctorOhh, PeterT, kovid) to update the first post and the index - see the top of index.
|
Ok great. I'll keep that in mind.
Quote:
|
Post test versions in a new messages. There'll be a few people to test new versions in current release calibre (i.e. 4.x) for Windows and MacOS, not so many for 4.99.x. You'll get more when Kovid calls for beta testers on what I assume will be calibre 5.
|
Do you mean posting it in a new message here? Or somewhere else?
Quote:
Regarding this plugin in particular:
- It has a feature to exclude duplicate groups from consideration whenever the plugin is run.
Some time after that feature was implemented in FD, Kovid implemented the user accessible marking of books in the calibre core (which deprecated the Temp Marker plugin). This plugin makes use of the same mechanism. IIRC it keeps a list of excluded groups in the database, when the plugin is loaded (or on a library switch) it uses the list to re-mark the books - which confuses users.
The solutions that have come to mind is to avoid the existing temporary mark mechanism, and implement a 'plugins only' marking mechanism, and/or defer the re-marking of books to when the search for duplicates is executed.
- And there's this problem ==>> How to fix Search showing all books with matches highlighted
I can't recall the circumstances when that happens, I don't think it relates to excluded groups.
Added: it either needs to restore the standard search highlight/filter setting back to what it was (but, when it would do that might be the question), or use a plugin specific approach
It would be good to get those issues resolved - probably after the py3 dust settles.
|
Ok great. I won't give any promises at this stage, but it would be nice to have a look at those. Although I'm fairly novice as far as programming goes, so porting to python3 without introducing any new bugs is probably the first step (at least as far as I'm concerned).
Speaking of which, I've already run 2to3 over this plugin code, but I'm still struggling a little to get a python3 instance of Calibre up and running so I can start doing some preliminary testing. Unfortunately, the dev instructions don't appear to work with Python3 (it's still running python2). On reflection that makes sense as the binary install would be pre-compiled. Anyway, I'll hopefully work that out and get back to this...
Thanks again for the warm welcome and friendly advice.
