Quote:
Originally Posted by Jeremy_D
Hi all,
I'm keen to have a go at porting this plugin to python3. According to the Calibre plugin stats, "Find Duplicates" is pretty popular and according to the py3 plugin port post it hasn't yet been done.
Is the original developer still floating about? If so are you ok with me working on a port? If not, does anyone else know if someone has already started work on this?
Also, does an existing public revision control (preferably git) repo already exist for this? Or should I just start a new one on GitHub?
Finally, assuming I do work on this, I'm a Linux only user, so to ensure it works on all platforms, are there other OS users who are interested in testing the py3 port? |
The original developer (kiwidude) logs in occasionally, I suggest you send him a PM as a courtesy.
Use whatever version control you're comfortable with, but the distribution of the
release versions must be via the Plugin Updater process - as per the stickies at the top of the Plugins sub-forum. The forum lacks a facility to assign a thread to a different member; so, that means having to ask one of the active mods (me, theducks, DoctorOhh, PeterT, kovid) to update the first post and the index - see the top of index.
Post test versions in a new messages. There'll be a few people to test new versions in current release calibre (i.e. 4.x) for Windows and MacOS, not so many for 4.99.x. You'll get more when Kovid calls for beta testers on what I assume will be calibre 5.
Regarding this plugin in particular:
- It has a feature to exclude duplicate groups from consideration whenever the plugin is run.
Some time after that feature was implemented in FD, Kovid implemented the user accessible marking of books in the calibre core (which deprecated the Temp Marker plugin). This plugin makes use of the same mechanism. IIRC it keeps a list of excluded groups in the database, when the plugin is loaded (or on a library switch) it uses the list to re-mark the books - which confuses users.
The solutions that have come to mind is to avoid the existing temporary mark mechanism, and implement a 'plugins only' marking mechanism, and/or defer the re-marking of books to when the search for duplicates is executed.
- And there's this problem ==>> How to fix Search showing all books with matches highlighted
I can't recall the circumstances when that happens, I don't think it relates to excluded groups.
Added: it either needs to restore the standard search highlight/filter setting back to what it was (but, when it would do that might be the question), or use a plugin specific approach
It would be good to get those issues resolved - probably after the py3 dust settles.
BR