View Single Post
Old 01-13-2020, 12:11 PM   #18
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,691
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
I guess we could build a do_not_update_me map of all broken links and pass it along the universal updates code. We could then have it check each link against that list before trying to update it. That would mean touching and fixing the universal updates code for every resource type.

If this only matters for AddExisting html or ImportHTML, we might be able to change the link in the html code to be effectively external. We could for example change a broken link such as:

../Styles/sheet1.css

to

fixme://../Styles/sheet1.css

so that it would go untouched by the universal updates code. We could leave it like that, so that the user could easily find any broken links with a simple search, or parse the xhtml file with gumbo and strip the fixme: somehow.

Thoughts?
It definitely only matters for Add Existing/Import HTML from my point of view.

If they must be changed at all (and I still don't quite follow why we'd want to alter an unusable css/image link into different unusable css/image link), I guess I'd have no problem with a fixme:// protocol being added. But would it survive any and all QUrl finagling the various Sigil features might do it before it was fixed?

Last edited by DiapDealer; 01-13-2020 at 12:25 PM.
DiapDealer is offline   Reply With Quote