View Single Post
Old 12-10-2019, 12:50 PM   #29
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 29,139
Karma: 211348980
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by BeckyEbook View Post
And by the way I looked at these new changes in the upcoming Calibre 4.5 and I'm also impressed. I'm just using the dark theme for Windows 10.
@kovidgoyal approached this problem very comprehensively and worked out his solution step by step.
MacOS/Linux users can use the CALIBRE_USE_DARK_PALETTE variable, and for Windows 10 users, all they need is dark theme on the system.
I'll be very interested in taking a look at his approach. To be honest, upgrading to Windows 10 1909 is the only reason I know that Windows even HAS a dark theme. I'm sure it was there earlier, but I never saw it.

EDIT: I see he's basically using the approach that everybody is using: using QPalette to get most of the way there, and then QStyles and icons to get the rest of the way (plus checking the Windows registry key for LightMode/DarkMode). Nothing fancy, just a ton of icon work I don't relish the thought of undertaking. Not to mention tackling the basic hurdle of being able to easily override Sigil's icons (which is been a part of calibre for a long, long time). In other words ... work. Ugh. I was hoping for a magic button.

Last edited by DiapDealer; 12-10-2019 at 01:05 PM.
DiapDealer is online now   Reply With Quote