View Single Post
Old 12-10-2019, 11:14 AM   #24
BeckyEbook
Guru
BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.BeckyEbook ought to be getting tired of karma fortunes by now.
 
BeckyEbook's Avatar
 
Posts: 876
Karma: 3501146
Join Date: Jan 2017
Location: Poland
Device: Various
Quote:
Originally Posted by KevinH View Post
Okay, I have pushed changes to implement Nos. 1 (? QWhatsThis), 4 (prettifying empty xhtml files), and 6 (extended support for other. type Guide semantics).

For 6, I have extended the list of recognized guide items to include many of the other.* codes that directly map to epub3. These codes will be recognized by the ncxgenerator.py code as well, as well as epub3-itizer.
I just noticed new commits.
I already have a private build.
Thank you! My possible Pull Request would not be so cool.

#1 & #4 – great.
#6 – I'm impressed. I didn't think about it myself, and that's a brilliant idea! While working on epub2 you can now use additional semantics.
I have only two comments (look at the attachment):
1. With "Rear Notes" there is a round bracket and no closing
2. "Footnotes" is missing (I checked the statistics and this is the most popular custom semantics epub2 ebooks in Polish). epub3-tizer already support other.footnotes.

--- * ---

#2 and #3 can be thought more carefully if the work on dark theme support were programmed.
Then the frame color and link color would be adjusted to all dark UI.

--- * ---

Quote:
Originally Posted by KevinH View Post
I will look into how the h* icon size is determined, as well. The case change icon is simply a text string which we could replace if someone would design a better icon for us! ;-)
I will prepare three new icons for the case format. Maybe even today.

@DiapDealer - I know that the problem with h* is icon related to Qt and in normal use is not a problem.

--- * ---

And by the way I looked at these new changes in the upcoming Calibre 4.5 and I'm also impressed. I'm just using the dark theme for Windows 10.
@kovidgoyal approached this problem very comprehensively and worked out his solution step by step.
MacOS/Linux users can use the CALIBRE_USE_DARK_PALETTE variable, and for Windows 10 users, all they need is dark theme on the system.
Of course @kovidgoyal also solved the problem #2 – the blue color of the links with the dark theme turned on is lighter.

If @KevinH and @DiapDealer will have spare capacity in the future – it's worth taking a look at the interesting solutions that are implemented in Calibre.
Attached Thumbnails
Click image for larger version

Name:	sigil-semantics-epub2.png
Views:	143
Size:	15.3 KB
ID:	175510  
BeckyEbook is online now   Reply With Quote