Quote:
Originally Posted by Norbi24
@Pazos,
I have just tried with the latest nightly (12.9.) and there are good and bad news.
The first part (allow overrides on 3rd party dictionary list) https://github.com/koreader/koreader...94cb2d59ddbee9
works like a charm, but the 2nd (add support for generic intents) https://github.com/koreader/android-...ab3636b4461173 not:
I added following 3 lines into the dictonaries.lua in koreader folder:
1st the standard way of configuring particular dict app, 2nd and 3rd two ways as how to initiate the picker send intent:
{ "HandyLexEsSk", "Lingea Handylex Plus (ES-SK)", false, "com.lingea.handylex.spskh2", "send" },
{ "GenericSend", "Choose Dict App On Translate", false, "org.koreader.launcher", "picker-send" },
{ "GenericSendNew", "Choose Dict App On Translate New2", false, nil, "send" },
1st works fine, but neither of 2nd nd 3rd does - the 3rd line is even always deactivated in the dict selection menu. Then if I select the 2nd, and mark a word for translation, no picker list gets displayed.
This is related with your checking "add support for generic intents":
On Sunday I locally checked out the last previous checkin, compiled and the 2nd line in the dictionaries.lua was again working fine
I have already written a comment to the checking "add support for generic intents".
Should any logs be helpful, please let me know
Gracias, Norbert |
It works as intended.
Your second example is obsolete and your 3rd example - which will do the same thing - needs to be true, to actually being enabled on your menu. Exactly like described in
https://github.com/koreader/koreader...ssue-348399680.
So in short: true and nil for an action to show the app picker. false and package name for an action to - after being checked at runtime - open the text directly in that app.
You can also set your local packages to "true", this will avoid runtime checks and save a whooping 0.5ms per each dict on your list.