Quote:
Originally Posted by KevinH
But it would certainly make things easier if we had a set of separate pull request for each the change you proposed so we can merge the ones people have no trouble with more easily. After everyone who wants to speaks up.
|
I will try to prepare a separate pull request for all proposals.
Quote:
Originally Posted by DiapDealer
#1 is reasonable enough, but we'd need to remember to ifdef it conditionally. AA_DisableWindowContextHelpButton was only introduced in Qt5.10, and we try to ensure that Sigil will build and function with at least limited functionality back to Qt5.9.4 on Linux.
|
Sure.
Quote:
Originally Posted by DiapDealer
#5 HOW DARE YOU! I slaved for minutes creating THAT icon!  But seriously... I hate icon work, I'd entertain reasonable replacement suggestions (as long as all three necessary sizes were supplied). To be honest, I'm not sure if I did that one or not (or if it's even an icon). I think I did the h* icon. |
Even now, h* doesn't work perfectly (depending on what state Sigil was closed in). If it was a 16px icon – it incorrectly switches to larger icon sizes when moving the slider. If it was a 22px or 48px icon – it should be fine.
Quote:
Originally Posted by odamizu
#3 - Just so I'm clear, this would be an optional, user-customizable thing? If so, I always like the idea of user-customizable options, though I'm not sure I would make use of the option as the default has always been fine for me.
|
Sure. The frame stays by default + optional borderlessness.
Quote:
Originally Posted by Tex2002ans
If someone goes out of their way to create a darker theme, is this link color not user-adjustable?
|
Qt unfortunately doesn't allow links to be styled
I have thoroughly analyzed the guidelines regarding contrast and visibility for people with sight diseases. Since there is no perfect solution (and perfect blue for links), I have to accept that adjustment for the disabled is more important than subjective aesthetics.
On the other hand, people with impaired eyesight would probably prefer not to use a dark theme, but a high contrast theme. Then the links are often yellow on a black background or similarly highly contrasting.
Quote:
Originally Posted by Tex2002ans
#6
Seems like the change wouldn't hurt.
But do you have an example of a book using this in the wild?
|
Of course.
I have 769 e-books bought from Polish bookstores. 83 of them (10.8%) was used semantics of "other." in the guide section.