View Single Post
Old 12-08-2019, 08:22 AM   #32
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,257
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
@Kovid,

Thanks very much for Windows nightmode.

I spent a few hours with it yesterday without too many problems, but I did notice a few things for possible further consideration before initial release.
  1. Editor TOC panel. The expand/collapse chars for nested entries are no longer visible (see screencap) unless the mouse is hovering over them. The TOC Editor does not have the same issue.
  2. Separator lines in a sub-menu are no longer visible (QMenu.addSeparator()).
  3. If anyone has a plugin which uses QPushButton.setDown() to show whether an option is on/off then it is no longer easy to see a visible difference between True/False settings. I was able to find a workaround for my own plugin which previously used .setDown().
  4. This is probably stating the obvious but quite a lot of the standard Editor icons are not currently suited to nightmode, e.g. Smart Comment, Insert tag and most of the Text formatting ones (bold, italic, subscript, align-left, etc)

I attach a screencap showing issues 1 and 4.
  • TOC Parts One, Two and Three should all be displaying a visible '>' expand char.
  • I've placed quick & dirty customised icons for Bold/Italic/Heading in my config resources/images directory but the Subscript/Superscript icons on the far right are typical of what the average user is going to see for text formatting options.
Attached Thumbnails
Click image for larger version

Name:	editor_nightmode.JPG
Views:	190
Size:	36.5 KB
ID:	175447  
jackie_w is offline   Reply With Quote