View Single Post
Old 12-01-2019, 12:51 PM   #5
pazos
cosiņeiro
pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.pazos ought to be getting tired of karma fortunes by now.
 
Posts: 1,406
Karma: 2451781
Join Date: Apr 2014
Device: BQ Cervantes 4
Quote:
Originally Posted by Norbi24 View Post
@Pazos, Thanks also for this tip, and allow me just one idea - wouldn't you mind to make the same also with the dictionaries.lua file ?
Simply at first try to load it from koreader folder (or koreader/android ?), and if not found, use the default one from /data/data/org.koreader.launcher/files/frontend/device/android/discionaries.lua ...

This would make experimenting with 3rd party dictionary apps much more easy

Thanks, Norbert
Sounds nice but I'm not interested .

IMO the list of dicts is not something worth custom settings. It takes less than 1 millisecond to check if each app of the list is installed and enabled, and that check is only performed once during the lifetime of the application.

Your best bet is to request specific dict apps or rebuild KO yourself with the changes you need. The current implementation, albeit very basic, should be able to open most of 3rd party applications. Some of them need custom intents and they need a modification in https://github.com/koreader/android-...IntentUtils.kt and thus require a rebuild to work.

Feel free to open a new ticket on the issue tracker if you wish. It might be possible to override the dict list without rebuilding somehow, but I have no idea.

Aaand, if you manage to get a new dict working with KO please give us feedback so we can add it to the list bundled with the application and other users can benefit too. Thanks!
pazos is offline   Reply With Quote