View Single Post
Old 11-20-2019, 10:09 AM   #12
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,765
Karma: 206758686
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
This should now be fixed in master by overiding QDialog::reject() to invoke cancelPlugin first before exiting and by my tests this catches both the escape key and the x close.
Doitsu clued me in to one of his plugins that would consistently crash for me when clicking the close button (or hitting ESC) while the plugin's gui (PyQt5) was open. Your commit eliminated the crashing (using ESC as well)

Last edited by DiapDealer; 11-20-2019 at 10:14 AM.
DiapDealer is online now   Reply With Quote