View Single Post
Old 11-16-2019, 11:04 AM   #157
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,709
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
That's about when we left Qt5.11 behind (0.9.15 was the prelease for QtWebEngine/Qt5.12). I'm guessing it was a change in behavior in Qt5.12.

Either way: m_CurrentHTMLResource in Dialogs/SelectHyperlink.cpp has been NULL since time began and the feature still worked. So it (m_CurrentHTMLResource) seemed to have no bearing on the conditionals it was being used in back when it WAS still working. That's crazy.

Basically, the list of resources being passed to Dialogs/SelectHyperlink.cpp was used (which included the current resource as well), while the null resource seemed to be ignored altogether.

The gist of the logic to my eyes, was to add the targets from the currently selected item first, and then the rest of targets from the book. So all the targets were still present, there was simply no prioritizing of the list going on.

Last edited by DiapDealer; 11-16-2019 at 11:20 AM.
DiapDealer is offline   Reply With Quote