Quote:
Originally Posted by Rev. Bob
Hmm.
Okay, on the one hand, I agree with you that image removal ought to be checking the CSS, so at least from the conceptual angle, it's a bug. Not a new one, though, which leads me to two counterpoints.
First, not being new, fixing it is of necessity further down my list than squashing any bugs introduced in the new version.
Second, the help file description of the routine only claims to check HTML; it says nothing about going through the CSS:
(Emphasis mine.)
Finally, but by no means least significant: In studying modify.py and container.py, I see a way to search CSS files for given strings; the XPGT removal does that. However, I don't see a good way to scan the CSS for general classes (like "images"), and I'm not familiar enough with that routine to be confident that I could quickly hack it to properly check for relative paths - that is, to distinguish "../images/separator.jpg" in 1/css/styles.css from "../images/separator.jpg" in 2/stylesheet.css.
So, as much as I'd like to see this fixed, and as willing as I am to incorporate a patch from someone else in the community, I think that's going to have to wait for a later release.
|
Personally, I don't like the way it the images were done in CSS. I think they should be done in the HTML code. It makes it a lot easier to see where these images are being used in the HTML when you see the image code.
But the one thing I do like is that I have the original ePub and I was able ot go into the original ePub, grab the two images and put them back into the ePub. Problem solved.