View Single Post
Old 09-22-2019, 01:52 PM   #45
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,805
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
Quote:
Originally Posted by MGlitch View Post
A thought for future patch releases, would it be possible to group the patches which are exclusive to each other together and mentioning at the start of that grouping that the patches are exclusive to each other?
The main reason for the confusing grouping right now is that the patches are split between multiple owners, which each have their own section. I'll see if there's anything reasonable I can do about this. One possibility could be to automatically reorder patch groups during the build.

Quote:
For example it seems almost every firmware cycle there's someone who is thrown by the home screen patches, cover size in library, remove 3rd row, and then cover size + remove third row.
Yes, I've noticed that too.

Quote:
I know Geoff used to remark in the patches when they were exclusive to each other. I think this would save future patchers some frustration. I'm not sure, but I believe the order the patches are in in the .yaml file is largely irrelevant save for tracking error responses.
They are still marked (see the PatchGroup instruction). And yes, the order is almost completely irrelevant. Everything is parsed all at once (well technically, it's parsed in layers, see the code for what I mean), and only line numbers are preserved for errors.
geek1011 is offline   Reply With Quote