MobileRead Forums - View Single Post

NiLuJe · 06-30-2019, 05:23 PM

@wesley6j:

Random remarks:

I'd either piggyback on the Forma's PgTurn keycodes (even if it requires basically enforcing hasKeys = true for every Kobo model for that to be honored), or adding brand new keycodes, because right now, you're effectivley killing SleepCover & Light button handling

.

I'd also ship the KOReader patch as a diff and apply it client-side (or device-side, the Kobo busybox build appears to ship with the patch applet included)

.

06-30-2019, 05:23 PM	#38
NiLuJe BLAM! Posts: 13,507 Karma: 26047202 Join Date: Jun 2010 Location: Paris, France Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E	@wesley6j: Random remarks: I'd either piggyback on the Forma's PgTurn keycodes (even if it requires basically enforcing hasKeys = true for every Kobo model for that to be honored), or adding brand new keycodes, because right now, you're effectivley killing SleepCover & Light button handling . I'd also ship the KOReader patch as a diff and apply it client-side (or device-side, the Kobo busybox build appears to ship with the patch applet included) . Last edited by NiLuJe; 06-30-2019 at 05:26 PM.