Thread: kobopatch - An improved patching system
View Single Post
Old 02-26-2019, 10:11 PM   #280
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,808
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
Quote:
Originally Posted by DNSB View Post
Hmmm... would you not need to either recurse since you are a level above the out directory or specify the path in the command? I noticed the existing version does not work on a Windows system and a quick test on an OpenSUSE Tumbleweed VM didn't work there either.

Code:
linux-6vh3:~ # cd /home/david/Desktop/Kobopatch_4.xx.yyyyy
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # dir
total 24
drwxr-xr-x 2 david users  263 Feb 26 18:27 bin
-rwxrw-rw- 1 david users   92 Feb 26 18:29 kobopatch.bat
-rwxrw-rw- 1 david users  546 Feb  6 17:07 kobopatch.sh
-rwxrw-rw- 1 david users 6855 Feb 26 18:30 kobopatch.yaml
-rwxrw-rw- 1 david users 1839 Feb  6 17:07 kobopatch.yaml.org
drwxr-xr-x 2 david users   90 Feb 26 18:30 out
-rwxrw-rw- 1 david users 1154 Feb  6 17:07 readme.txt
drwxr-xr-x 2 david users  178 Feb 26 18:28 src
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # dir out
total 14916
-rwxrw-rw- 1 david users 15230116 Feb 26 18:30 KoboRoot.tgz
-rwxrw-rw- 1 david users    39622 Feb 26 18:30 log.txt
-rwxrw-rw- 1 david users        0 Feb  6 17:07 run_kobopatch_to_generate_these_files.txt
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # rm -f "KoboRoot.tgz"
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # dir out
total 14916
-rwxrw-rw- 1 david users 15230116 Feb 26 18:30 KoboRoot.tgz
-rwxrw-rw- 1 david users    39622 Feb 26 18:30 log.txt
-rwxrw-rw- 1 david users        0 Feb  6 17:07 run_kobopatch_to_generate_these_files.txt
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # rm -f "./out/KoboRoot.tgz"
linux-6vh3:/home/david/Desktop/Kobopatch_4.xx.yyyyy # ls -al out
total 40
drwxr-xr-x 2 david users    70 Feb 26 18:52 .
drwxr-xr-x 5 david users   146 Feb 26 18:27 ..
-rwxrw-rw- 1 david users 39622 Feb 26 18:30 log.txt
-rwxrw-rw- 1 david users     0 Feb  6 17:07 run_kobopatch_to_generate_these_files.txt
Oh, I see your point now. Note that the command isn't completely necessary; kobopatch will replace an existing KoboRoot.tgz. It's mainly there to prevent confusion if an error causes kobopatch to fail, and the old tgz is left there. I'll have the script updated for the next version.

You seem to be quite proficient at catching my mistakes while refactoring!
geek1011 is offline   Reply With Quote