View Single Post
Old 02-16-2019, 08:01 PM   #9
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,918
Karma: 6240958
Join Date: Nov 2009
Device: many
We will continue to use our embedded version for the next release and then switch over to using our PyPI version after that. That said, css_parser will not be an optional python package (ie. it must be treated like lxml) as it will be needed for Sigil proper to work if anyone asks Sigil to prettify a css stylesheet.

You should be able to use the pypi version now and simply add a script to remove the embedded version until we get aroung to it. Nothing else need be changed.

Yes that css parser change is to fix a bug that broke parsing of calc( 1 / 1 ) and similar things where ratio products needed only for media queries interfered with calcs that used integer ratios.

Quote:
Originally Posted by eschwartz View Post
Speaking of... have you had a chance to look at maybe devendoring this and using the version from PyPI? If you're happy with the changes, then I guess you could simply tag a new css_parser release.

@KevinH, any specific Sigil issue this change is fixing? https://github.com/ebook-utils/css-p...f885286325a977



On it roughly soonish.
KevinH is online now