View Single Post
Old 02-08-2019, 08:10 PM   #36
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,836
Karma: 7454317
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour
Quote:
Originally Posted by davidfor View Post
I don't think I have seen any mention of most of that before.
I've mentioned it in bits and pieces scattered around many places. I'll be consolidating it for kepubify v3.

Quote:
And I don't know what firmware bugs you are fixing. For example, I cannot remember mention of a bug in kepubs that needed the CSS to be inlined to fixed.
https://www.mobileread.com/forums/sh....php?p=3769235

Quote:
And what are the other changes? You don't mention anything about them on the kepubify page. Is there a list somewhere of what is done?
Most are in the command documentation, some I've removed after the need was gone. You can find the most up-to-date information in: https://github.com/geek1011/kepubify...kepub/kepub.go

Quote:
And how is the custom CSS handled? Added to each stylesheet, as a separate stylesheet or internal to the page? Does the stylesheet inlining do the latter or add stylesheets to each tag?
Custom CSS is currently added before the body tag end after all other CSS tweaks. Inlining adds the stylesheet as a style tag in the same place the link tag was (to preserve precedence).

Quote:
Some of this I could see by running kepubify with the different options. But, others would need books with those problems to see. But, as the kepubify page doesn't mention some of this, I wouldn't even be looking for it.
That's partly the intention. You aren't supposed to notice the fixes unless they are necessary. But, I agree they need to be documented properly. That will be resolved in kepubify v3.
geek1011 is offline   Reply With Quote