Thread: Instructions for patching firmware 4.4.9298
View Single Post
Old 01-05-2019, 08:21 AM   #83
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by jcn363 View Post
EDITē:
Into libnickel:
The 'Dictionary text font-family/font-size/line-height - beta' (for libnickel.so.1.0.0) has been a part of the standard patch pack for a long time. I have the responsibility for maintaining it. Why are you rewriting it?

If you think you've got some good ideas how to improve it then the polite thing to do would be to discuss it with me in one of the patch threads. If appropriate, I can then incorporate any improvements into the standard pack. However, in this particular case, the code you highlighted in red is already part of the standard patch. What are you hoping to achieve?

IMHO rewriting someone else's patch without reference to the original is extremely rude and it's not the first time you've done something similar. We already have enough problems with conflicting patches without you making it worse.
jackie_w is offline   Reply With Quote