View Single Post
Old 10-23-2018, 06:39 PM   #30
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,691
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
BTW, you have to make the same change to add setIniCodec to utf-8 in the SaveData() routine in Sigil/src/MiscEditors/SearchEditorModel.cpp to get things to work properly in Find and Replace ini files too.

Of course, if we decide to make this change, we can always just change Sigil/src/Misc/SettingsStore.cpp and add the call to setIniCodec in the constructor to make sure all instances of SettingsStore properly set the ini codec, that way we will not miss anyplace, and we do not have to hunt to find everyplace where SettingsStore is used.

Thoughts?

KevinH
Unless we can envision a situation where individual config files might need to be something other than utf-8, I like the idea of the latter, one-size-fits-all approach, myself.

I'll try to do some testing on Linux and Windows soon.
DiapDealer is offline   Reply With Quote